Skip to content

Conversation

@sgrayson21
Copy link

@sgrayson21 sgrayson21 commented Nov 26, 2018

Relevant to issue #299.

This exposes the fetch size parameter on the prepared statement. This is needed for Postgres connections for large data sets, or any connection that does not set a fetch size by default, so that the connection does not attempt to bring back all the data in one giant payload.

https://jdbc.postgresql.org/documentation/head/query.html

I also fixed the tests around reflection. The test coverage library seems to inject synthetic fields in all Java classes for measurements. All that needed to be done was filter out the synthetic fields in the reflection unit tests.

I also added a unit test around my change.

@sgrayson21
Copy link
Author

sgrayson21 commented Nov 27, 2018

I'm having some trouble with the test coverage. There is not a lot of added code here to test, so initially I added some small additions to a couple existing tests, then tried adding a whole new test to see if that made the test coverage happy. Even only adding a setFetchSize stub that did nothing and verifying it got called got denied.

What exactly am I doing wrong with the test coverage, or is this expected?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant