fix: simplify donut chart schema for OpenAI compatibility#8303
Open
mvanhorn wants to merge 1 commit intoaaif-goose:mainfrom
Open
fix: simplify donut chart schema for OpenAI compatibility#8303mvanhorn wants to merge 1 commit intoaaif-goose:mainfrom
mvanhorn wants to merge 1 commit intoaaif-goose:mainfrom
Conversation
Collaborator
|
@mvanhorn seems reasonable - so always a list? Mind signing the DCO for a clean build? |
Replace DonutChartData untagged enum with Vec<SingleDonutChart>. The untagged enum generated oneOf/anyOf in JSON Schema, which OpenAI's function calling validator rejects. Now data is always an array, eliminating the schema ambiguity. Picks up from aaif-goose#8182 which was reviewed favorably then self-closed. Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
mvanhorn
force-pushed
the
fix/8173-autovisualiser-donut-schema
branch
from
b31bc32 to
af46196
Compare
Author
|
Yep, always a list. Signed the DCO in af46196. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the
DonutChartDatauntagged enum withVec<SingleDonutChart>in the autovisualiser'srender_donuttool. The#[serde(untagged)]enum generatedoneOf/anyOfin JSON Schema, which OpenAI's function calling schema validator rejects withInvalid schema for function 'autovisualiser__render_donut'.Changes
In
crates/goose-mcp/src/autovisualiser/mod.rs:DonutChartDataenum (the#[serde(untagged)]source of the schema issue)RenderDonutParams.datafromDonutChartDatatoVec<SingleDonutChart>validate_donut_charts(&[SingleDonutChart])text_fallbackto handle single vs multiple charts from the array lengthTesting
All 38 autovisualiser tests pass, including updated donut tests:
test_render_donut- single chart as one-element arraydonut_rejects_empty_values- validation still catches empty valuesdonut_rejects_mismatched_labels- label count mismatch still caughtdonut_rejects_empty_multiple- empty array rejectedPicks up from #8182 which was reviewed favorably by @DOsinga then self-closed by the author.
Fixes #8173
This contribution was developed with AI assistance (Codex).