fix: correct showCellNumbers default and docs syntax error#7
Merged
abhay-ramesh merged 1 commit intomainfrom Mar 27, 2026
Merged
fix: correct showCellNumbers default and docs syntax error#7abhay-ramesh merged 1 commit intomainfrom
abhay-ramesh merged 1 commit intomainfrom
Conversation
Two small correctness bugs: 1. NotebookLoader defaulted showCellNumbers to true, but the docs table, directive option reference, and NotebookCodeCell all document the default as false. Align the component default with the documented behaviour. 2. The getMDXComponents example in docs/index.mdx was missing a trailing comma after `...components`, producing a JavaScript syntax error when users copy-paste it. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Two small correctness bugs caught during a codebase audit:
1.
showCellNumbersdefault mismatchNotebookLoaderwas defaultingshowCellNumberstotrue, but:falseNotebookCodeCellalso defaults it tofalseThis meant cell numbers appeared unexpectedly for anyone using the
:::notebookdirective without explicitly settingshowCellNumbers.Fix: Change the
NotebookLoaderdefault fromtrue→false.2. Missing comma in
getMDXComponentsdocs exampleThe code snippet in the getting-started guide was missing a trailing comma:
Copying this example verbatim produced a TypeScript compilation error.
Test plan
:::notebook{file="..."}withoutshowCellNumbersno longer shows cell numbers🤖 Generated with Claude Code