Add Electron desktop app (no proxy server needed)#21
Open
abhimanyusinghal wants to merge 1 commit intomasterfrom
Open
Add Electron desktop app (no proxy server needed)#21abhimanyusinghal wants to merge 1 commit intomasterfrom
abhimanyusinghal wants to merge 1 commit intomasterfrom
Conversation
Ports server/proxy.js logic to IPC handlers in the Electron main process so the desktop build runs HTTP, WebSocket, OAuth token exchange, and GitHub device flow without a sidecar Express server. The renderer detects desktop mode via window.curlit and branches transport while keeping payload shapes identical to the existing proxy endpoints.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
electron/directory contains the main process, preload, and IPC handlers ported fromserver/proxy.js-- HTTP, OAuth token exchange, GitHub device flow, and WebSocket relay all run in-process. The Express server is no longer required for desktop.isDesktop()helper insrc/utils/desktop.tsswaps transport at the four call sites that previously hit/api/proxy,/api/oauth/token,/api/github/*, and/api/ws-proxy.electron:dev,electron:build, and per-platform build scripts;electron-builder.ymlships NSIS / DMG (universal) / AppImage+deb targets.Test plan
npx tsc -bpassesnpx eslintclean on every file touched in this PRnpm test-- 459/459 tests pass (no regressions inhttp.ts,oauth.ts,github.ts, store, components, or proxy server)vite build --base=./produces a relative-pathdist/that loads fromfile://electron electron/main.cjsboots the prod build without errorsnpm run electron:devend-to-end smoke (send a real cross-origin GET, OAuth token exchange against a live IdP, WebSocket echo)npm run electron:build:winproduces a working NSIS installer