Add cache validation and atomic file operations #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcelBochtler
force-pushed
the
bad-zip-file
branch
from
9ef2a44 to
a0e2931
Compare
MarcelBochtler
changed the title
MarcelBochtler
force-pushed
the
bad-zip-file
branch
2 times, most recently
from
ccf48ca to
c752c84
Compare
Signed-off-by: Marcel Bochtler <[email protected]>
We've seen corrupted wheel files in Python Inspector's cache leading to `BadZipFile` exceptions. Add additional validation that ensures that files that will be reused from the cache are actual zip files. Signed-off-by: Marcel Bochtler <[email protected]>
When downloading and caching files such as Python wheels, eggs, or zip files, it's crucial to ensure that the files are fully and correctly written before they are made available for use. This change implements atomic file operations by writing to a temporary file first and then renaming it to the target filename once the write is complete and the file has been validated. This prevents issues where a partially written or corrupt file could be read by other processes. Signed-off-by: Marcel Bochtler <[email protected]>
Wrap cache file read in try-except to handle race condition where another async task deletes the file between validation and lock acquisition. Automatically retry with force=True to trigger re-download. Signed-off-by: Marcel Bochtler <[email protected]>
MarcelBochtler
force-pushed
the
bad-zip-file
branch
from
c752c84 to
90ffc2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.