Skip to content

feat: 添加物理读取页和逻辑读取页指标#3040

Merged
Seechi-Yolo merged 2 commits intomainfrom
fix_dm_topsql
May 16, 2025
Merged

feat: 添加物理读取页和逻辑读取页指标#3040
Seechi-Yolo merged 2 commits intomainfrom
fix_dm_topsql

Conversation

@Jarvis1105
Copy link
Copy Markdown
Contributor

@Jarvis1105 Jarvis1105 commented May 13, 2025

User description

关联的 issue

https://github.com/actiontech/sqle-ee/issues/2356

描述你的变更

添加实例审计计划物理读取页和逻辑读取页指标

确认项(pr提交后操作)

Tip

请在指定复审人之前,确认并完成以下事项,完成后✅


  • 我已完成自测
  • 我已记录完整日志方便进行诊断
  • 我已在关联的issue里补充了实现方案
  • 我已在关联的issue里补充了测试影响面
  • 我已确认了变更的兼容性,如果不兼容则在issue里标记 not_compatible
  • 我已确认了是否要更新文档,如果要更新则在issue里标记 need_update_doc

link https://github.com/actiontech/sqle-ee/pull/2365


Description

  • 添加 OrderByMap 中的新字段,用于统计实例审计计划的物理读取页和逻辑读取页指标

  • 更新后端查询模板,支持新添加的指标字段


Changes walkthrough 📝

Relevant files
Enhancement
instance_audit_plan_list.go
添加两个新指标字段                                                                                               

sqle/model/instance_audit_plan_list.go

  • 新增 "phy_read_page_total" 映射字段
  • 新增 "logic_read_page_total" 映射字段
+2/-0     

Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • @actiontech-bot actiontech-bot requested review from Seechi-Yolo and removed request for Seechi-Yolo May 13, 2025 10:22
    @github-actions
    Copy link
    Copy Markdown

    github-actions Bot commented May 13, 2025

    PR Reviewer Guide 🔍

    (Review updated until commit 8b5fd24)

    🎫 Ticket compliance analysis 🔶

    2356 - Partially compliant

    Compliant requirements:

    • 未见相关改动

    Non-compliant requirements:

    • 新增指标字段未涉及XML解析器配置更新

    Requires further human verification:

    • 需要确认新指标对现有查询模板的影响与集成测试结果
    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    命名一致性

    请检查新添加的字段名称与系统其余部分的一致性,确认JSON路径及查询模板配置正确,确保新指标字段不会引起意外的查询行为。

    "phy_read_page_total":     "audit_plan_sqls.info->'$.phy_read_page_total'",
    "logic_read_page_total":   "audit_plan_sqls.info->'$.logic_read_page_total'",

    @github-actions
    Copy link
    Copy Markdown

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @Jarvis1105 Jarvis1105 changed the title feat(model): 添加实例审计计划物理读取页和逻辑读取页指标 feat: 添加物理读取页和逻辑读取页指标 May 14, 2025
    Seechi-Yolo
    Seechi-Yolo previously approved these changes May 15, 2025
    # Conflicts:
    #	sqle/model/instance_audit_plan_list.go
    @github-actions
    Copy link
    Copy Markdown

    Persistent review updated to latest commit 8b5fd24

    @github-actions
    Copy link
    Copy Markdown

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @Seechi-Yolo Seechi-Yolo merged commit cc07c10 into main May 16, 2025
    4 checks passed
    @Jarvis1105 Jarvis1105 deleted the fix_dm_topsql branch May 16, 2025 02:09
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants