You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
-for _, userOpPermission := range p.opPermissionItem {- if userOpPermission.OpPermissionType == opPermissionType {- return &userOpPermission+for i := range p.opPermissionItem {+ if p.opPermissionItem[i].OpPermissionType == opPermissionType {+ return &p.opPermissionItem[i]
}
}
Suggestion importance[1-10]: 9
__
Why: The change addresses a subtle Go bug regarding pointers to loop variables and ensures that the proper permission element is returned. This correction is accurate and significantly improves the reliability of the function.
for idx, pipe := range pipelineList {
- err = data[idx].fillWith(pipe)+ if err = data[idx].fillWith(pipe); err != nil {+ return controller.JSONBaseErrorReq(c, err)+ }
}
Suggestion importance[1-10]: 8
__
Why: The suggestion improves error handling by checking the error return from fillWith, preventing possible panics. However, as it only adds an error check in a loop, its impact is important but within typical defensive programming practices.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
关联的 issue
https://github.com/actiontech/sqle-ee/issues/2387
描述你的变更
确认项(pr提交后操作)
Tip
请在指定复审人之前,确认并完成以下事项,完成后✅
not_compatibleneed_update_docDescription
修正流水线列表权限过滤逻辑
增加 data_sources 字段展示数据源信息
调整权限检查调用 GetOnePermission 方法
更新 API 文档和 Swagger 定义
Changes walkthrough 📝
2 files
更新流水线详情和权限过滤逻辑添加 GetOnePermission 权限查询方法3 files
增加 data_sources 文档描述更新 Swagger 中 data_sources 定义补充 Swagger data_sources 属性定义2 files
修改 GetPipelineList 签名及查询条件调整流水线列表查询参数传递