You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Why: The suggestion correctly identifies a type mismatch where HasOneOfPermission expects []v1.OpPermissionType while the current code supplies []dmsv1.OpPermissionType. Changing the parameter type in the function signature is important for avoiding compile errors, and as a type checking suggestion, the score is capped at 8.
Why: The suggestion simplifies the return logic by directly returning the boolean variable, which improves clarity and conciseness. It accurately matches the corresponding lines in the PR diff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
link https://github.com/actiontech/sqle-ee/pull/2411
关联的 issue
https://github.com/actiontech/sqle-ee/issues/2387
描述你的变更
修复当只有创建工单权限,创建工单报错: you have no permission to get rule templates in project
确认项(pr提交后操作)
Tip
请在指定复审人之前,确认并完成以下事项,完成后✅
not_compatibleneed_update_docDescription
新增hasViewPermissions用于多权限判断
添加UserPermission中HasSomsPermissions方法
Changes diagram
Changes walkthrough 📝
rule.go
添加批量权限判断API接口sqle/api/controller/v1/rule.go
permission.go
增加批量权限校验方法sqle/dms/permission.go