Skip to content

fix: save audit plan permission#3079

Merged
LordofAvernus merged 1 commit intomainfrom
fix_audit_plan_permit
Jul 4, 2025
Merged

fix: save audit plan permission#3079
LordofAvernus merged 1 commit intomainfrom
fix_audit_plan_permit

Conversation

@Jarvis1105
Copy link
Copy Markdown
Contributor

@Jarvis1105 Jarvis1105 commented Jul 4, 2025

User description

assign in @LordofAvernus
link https://github.com/actiontech/sqle-ee/pull/2436

关联的 issue

https://github.com/actiontech/sqle-ee/issues/2387#issuecomment-3035314273

描述你的变更

确认项(pr提交后操作)

Tip

请在指定复审人之前,确认并完成以下事项,完成后✅


  • 我已完成自测
  • 我已记录完整日志方便进行诊断
  • 我已在关联的issue里补充了实现方案
  • 我已在关联的issue里补充了测试影响面
  • 我已确认了变更的兼容性,如果不兼容则在issue里标记 not_compatible
  • 我已确认了是否要更新文档,如果要更新则在issue里标记 need_update_doc


Description

  • 将权限检查参数由 "OpPermissionTypeViewOtherAuditPlan" 修改为 "OpPermissionTypeSaveAuditPlan"

  • 统一审核计划接口中的权限判断逻辑

  • 修正项目和实例审核计划权限过滤错误


Changes diagram

flowchart LR
  A["审核计划权限校验"]
  B["从 ViewOther 转换为 SaveAuditPlan"]
  C["更新 V1 接口权限"]
  D["更新 V2 接口权限"]
  E["调整项目权限逻辑"]
  A -- "修改权限参数" --> B
  B -- "影响 V1 接口" --> C
  B -- "影响 V2 接口" --> D
  B -- "修改项目权限" --> E
Loading

Changes walkthrough 📝

Relevant files
Bug fix
audit_plan.go
更新 V1 接口中的权限判断参数                                                                                 

sqle/api/controller/v1/audit_plan.go

  • 修改权限参数传递,使用 SaveAuditPlan 替代 ViewOtherAuditPlan
  • 更新多个接口中权限判断的调用方式
+6/-6     
project_permission.go
优化项目权限判断逻辑                                                                                             

sqle/api/controller/v1/project_permission.go

  • 移除 ViewOtherAuditPlan 检查,仅保留 SaveAuditPlan 权限
  • 调整错误提示信息中操作类型描述
+3/-3     
audit_plan.go
更新 V2 审核计划权限逻辑                                                                                     

sqle/api/controller/v2/audit_plan.go

  • 修改实例名称获取权限参数为 SaveAuditPlan
  • 更新审核计划 SQL 接口的权限判断
+2/-2     
instance_audit_plan.go
更新实例审核计划权限过滤逻辑                                                                                     

sqle/api/controller/v2/instance_audit_plan.go

  • 修改实例审核计划权限过滤条件,移除 ViewOtherAuditPlan
  • 仅使用 SaveAuditPlan 进行权限检查
+1/-1     

Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • @actiontech-bot actiontech-bot requested review from LordofAvernus and removed request for LordofAvernus July 4, 2025 10:04
    @github-actions
    Copy link
    Copy Markdown

    github-actions Bot commented Jul 4, 2025

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @LordofAvernus LordofAvernus merged commit 8ff68b1 into main Jul 4, 2025
    4 checks passed
    @Jarvis1105 Jarvis1105 deleted the fix_audit_plan_permit branch July 4, 2025 10:21
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants