Skip to content

fix: not null rule when blob text#3081

Merged
BugsGuru merged 1 commit intomainfrom
fix_not_null_rule
Jul 8, 2025
Merged

fix: not null rule when blob text#3081
BugsGuru merged 1 commit intomainfrom
fix_not_null_rule

Conversation

@Jarvis1105
Copy link
Copy Markdown
Contributor

@Jarvis1105 Jarvis1105 commented Jul 8, 2025

User description

关联的 issue

https://github.com/actiontech/sqle-ee/issues/2438#issuecomment-3047739062

描述你的变更

确认项(pr提交后操作)

Tip

请在指定复审人之前,确认并完成以下事项,完成后✅


  • 我已完成自测
  • 我已记录完整日志方便进行诊断
  • 我已在关联的issue里补充了实现方案
  • 我已在关联的issue里补充了测试影响面
  • 我已确认了变更的兼容性,如果不兼容则在issue里标记 not_compatible
  • 我已确认了是否要更新文档,如果要更新则在issue里标记 need_update_doc


Description

  • 修正BLOB类型列不应参与非空校验

  • 新增isBlob函数判断是否为BLOB

  • 修改ALTER TABLE和CREATE TABLE列检查逻辑


Changes diagram

flowchart LR
  A["\"checkColumnNotNull 检查非空规则\""] -- "判断是否为BLOB" --> B["\"调用 isBlob 函数\""]
  B -- "返回判断结果" --> C["\"决定是否跳过非空校验\""]
Loading

Changes walkthrough 📝

Relevant files
Bug fix
rule.go
调整非空规则并新增BLOB类型判断                                                                               

sqle/driver/mysql/rule/rule.go

  • 在ALTER TABLE中增加BLOB判断条件
  • 在CREATE TABLE中增加BLOB判断条件
  • 新增isBlob函数判断列类型
  • +13/-2   

    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • @actiontech-bot actiontech-bot requested a review from BugsGuru July 8, 2025 07:40
    @github-actions
    Copy link
    Copy Markdown

    github-actions Bot commented Jul 8, 2025

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @BugsGuru BugsGuru merged commit 718c7bb into main Jul 8, 2025
    4 checks passed
    @BugsGuru BugsGuru deleted the fix_not_null_rule branch July 8, 2025 07:59
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants