Conversation
…rfaces, and update proto definitions
…in driver_v2.proto
… PluginImplV2, and add corresponding gRPC server handling
… extraction and enhance GetSelectivityOfSQLColumns method
PR Reviewer Guide 🔍
|
|
Failed to generate code suggestions for PR |
BugsGuru
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
关联的 issue
https://github.com/actiontech/sqle-ee/issues/2572
描述你的变更
新增获取SQL中列选择性插件接口,并在MySQL插件中实现
确认项(pr提交后操作)
Tip
请在指定复审人之前,确认并完成以下事项,完成后✅
not_compatibleneed_update_docDescription
新增 SQL 列选择性接口
添加 SQL 解析和列提取逻辑
扩展 GRPC 与插件支持
更新接口定义及 protobuf 消息
Diagram Walkthrough
File Walkthrough
6 files
添加 MysqlDriverImpl 的 GetSelectivityOfSQLColumns 方法添加 ExtractColumnsFromSelectStmt 工具函数增加 GRPC 处理 GetSelectivityOfSQLColumns 接口实现 PluginImplV2 的 GetSelectivityOfSQLColumns 方法添加 PluginImplV1 未实现的 GetSelectivityOfSQLColumns 方法添加 DriverImpl 的 GetSelectivityOfSQLColumns 方法桩3 files
添加 Driver 接口 GetSelectivityOfSQLColumns 定义添加 Plugin 接口 GetSelectivityOfSQLColumns 定义增加 proto 消息和 rpc 接口定义1 files
添加 mockDriver 的 GetSelectivityOfSQLColumns 测试方法1 files