refactor: Handle navigation surfaces by pointer to feed surfaces outside the tracking geometry #4494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andiwand
reviewed
Jul 30, 2025
|
|
||
| /// External surface identifier for which the boundary check is ignored | ||
| std::vector<GeometryIdentifier> externalSurfaces = {}; | ||
| std::vector<const Surface*> externalSurfaces{}; |
There was a problem hiding this comment.
one thing we need to consider is if this should take ownership of the surfaces or if raw pointers are fine. if these surfaces are not part of the geometry, the user would have to take care of their lifetime right now
|
junggjo9
force-pushed
the
RefactorNav
branch
from
19780dd to
d47a68b
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLEASE DESCRIBE YOUR CHANGES.
THIS MESSAGE ENDS UP AS THE COMMIT MESSAGE.
DO NOT USE @-MENTIONS HERE!
--- END COMMIT MESSAGE ---
Any further description goes here, @-mentions are ok here!
feat,fix,refactor,docs,choreandbuildtypes.