-
Notifications
You must be signed in to change notification settings - Fork 218
feat: Add NVTX ranges to GNN code #4527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Does this need to be steered from CMake? Could you make this conditional on |
I'm not sure about the performance impact of this tbh. Maybe @stephenswat has some insight in this. |
@benjaminhuth Conclusion? I would prefer if we could avoid making this an explicit option, but ok if we have to. |
I am with Paul on this, I would unconditionally enable this and not bother with the CMake flag. |
This improves analysis of device parallelism with nsight-systems.