feat: Add jet labeling, jet overlap removal and HepMC3 event #4680
Conversation
…o trackToTruthAlg
…o trackToTruthAlg
Co-authored-by: Paul Gessinger <[email protected]>
Co-authored-by: Paul Gessinger <[email protected]>
github-actions
bot
added
Component - Core
|
There was a problem hiding this comment.
Here's some comments on the preliminary version of the PR.
I think it might make sense to try to break this up further. I think the changes to the HepMC3 conversion flow, and also the additional index attribute are independent from the other changes (might have to go first, though).
Let me know what you think @delitez!
| return std::make_pair(Z, A); | ||
| } | ||
|
|
||
| enum class HadronType { |
There was a problem hiding this comment.
This file contains code I pulled from ATLAS. I don't think we have precedence for this. From a license point of view, I think this is fine (and @EdwardMoyse had informally confirmed this).
There was a problem hiding this comment.
Consider breaking this out into a separate PR.
There was a problem hiding this comment.
Consider breaking this out into a separate PR. The idea is that we can later use this by convention to identify the hard-scatter event.
2 participants
This PR follows the PR #4637 and adds jet labeling, overlap removal and access to pythia-8 truth particles via inclusion of HepMC3Event for jet clustering and track-to-jet matching algorithms.