Skip to content

Conversation

asalzburger
Copy link
Contributor

@asalzburger asalzburger commented Oct 10, 2025

This PR moves the Plugins related code into Python/Plugins - each plugin will appear in a dedicated library ActsPluginsPythonBinding@PluginName@ and for each plugin a dedicated plugin_name.py is autogenerated that:

  • guards the import and throws a warning if the import doesn't work
  • applies the _patch_config from the adapter.

The dependencies now look pretty clear, with this PR:

  • only one occasion in Examples/Python refers back to the main module, this is due to the FpeMonitor being in python, but only making sense in the context of the Examples.
  • only one module defines actually plugin bindings, i.e. the GNN because the backends are only defined there.

This PR will be followed by one doing the same for Examples/Python -> Python/Examples.

It should not change test results.

--- END COMMIT MESSAGE ---

"main" module needed only in Framework

Screenshot 2025-10-16 at 11 06 29

Very strong reduction of ActsPlugins appearance in Python/Examples:

Screenshot 2025-10-16 at 11 05 50

Any further description goes here, @-mentions are ok here!

  • Use a conventional commits prefix: quick summary
    • We mostly use feat, fix, refactor, docs, chore and build types.
  • A milestone will be assigned by one of the maintainers

@github-actions github-actions bot added this to the next milestone Oct 10, 2025
@github-actions github-actions bot added the Component - Examples Affects the Examples module label Oct 10, 2025
Copy link
Contributor

github-actions bot commented Oct 10, 2025

📊: Physics performance monitoring for 5e37898

Full contents

physmon summary

@github-actions github-actions bot added the Component - Plugins Affects one or more Plugins label Oct 16, 2025
ExamplesIoRoot
SHARED
src/RootMeasurementWriter.cpp
src/RootMaterialDecorator.cpp
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was malplaced, it should (and now does) live in ActsPlugins/Root this is corrected here such that the Plugins python bindings are already correct.

@github-actions github-actions bot added the Infrastructure Changes to build tools, continous integration, ... label Oct 17, 2025
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins Infrastructure Changes to build tools, continous integration, ...

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant