-
Notifications
You must be signed in to change notification settings - Fork 219
chore: move Plugin python bindings into Python/Plugins
#4705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
asalzburger
wants to merge
37
commits into
acts-project:main
Choose a base branch
from
asalzburger:chore-move-Plugins-PythonBindings
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
chore: move Plugin python bindings into Python/Plugins
#4705
asalzburger
wants to merge
37
commits into
acts-project:main
from
asalzburger:chore-move-Plugins-PythonBindings
+1,179
−949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asalzburger
commented
Oct 16, 2025
ExamplesIoRoot | ||
SHARED | ||
src/RootMeasurementWriter.cpp | ||
src/RootMaterialDecorator.cpp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was malplaced, it should (and now does) live in ActsPlugins/Root
this is corrected here such that the Plugins python bindings are already correct.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component - Examples
Affects the Examples module
Component - Plugins
Affects one or more Plugins
Infrastructure
Changes to build tools, continous integration, ...
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the Plugins related code into
Python/Plugins
- each plugin will appear in a dedicated libraryActsPluginsPythonBinding@PluginName@
and for each plugin a dedicatedplugin_name.py
is autogenerated that:_patch_config
from the adapter.The dependencies now look pretty clear, with this PR:
Examples/Python
refers back to the main module, this is due to theFpeMonitor
being in python, but only making sense in the context of the Examples.GNN
because the backends are only defined there.This PR will be followed by one doing the same for
Examples/Python
->Python/Examples
.It should not change test results.
--- END COMMIT MESSAGE ---
"main" module needed only in
Framework
Very strong reduction of
ActsPlugins
appearance inPython/Examples
:Any further description goes here, @-mentions are ok here!
feat
,fix
,refactor
,docs
,chore
andbuild
types.