fix: Avoid venv race condition in offline build #4710
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In acts-project#4676, I implemented the possibility to use the code generation tooling for the ACTS code generation in an offline environment by creating a single virtual environment and reusing it across multiple custom targets. While this works naively, it introduces a race condition in which multiple threads modify the same virtual environment at the same time. In order to resolve this problem, I changed the build system to use a separate virtual environment for every code generation target.
github-actions
bot
added
the
Infrastructure
paulgessinger
approved these changes
Oct 14, 2025
|
Unfortunately this will need a bit of follow-up work still, as I had misunderstood the core problem. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #4676, I implemented the possibility to use the code generation tooling for the ACTS code generation in an offline environment by creating a single virtual environment and reusing it across multiple custom targets. While this works naively, it introduces a race condition in which multiple threads modify the same virtual environment at the same time. In order to resolve this problem, I changed the build system to use a separate virtual environment for every code generation target.