Skip to content

fix formula date variable in rules #7373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youngcw merged 3 commits into from
Apr 8, 2026
Merged

fix formula date variable in rules #7373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f8918d9
format
youngcw Apr 3, 2026
8ce6210
note
youngcw Apr 3, 2026
e4f891a
update test
youngcw Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/desktop-client/src/hooks/useFormulaExecution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,6 +329,7 @@ export function useFormulaExecution(
licenseKey: 'gpl-v3',
localeLang: typeof locale === 'string' ? locale : 'en-US',
language: 'enUS',
dateFormats: ['DD/MM/YYYY', 'YYYY-MM-DD', 'YYYY/MM/DD'],
Copy link
Copy Markdown
Member

@matt-fidd matt-fidd Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a breaking change as non-US dates are used by default, but for the future we should look at using the user date pref to set this if possible.

Copy link
Copy Markdown
Member Author

@youngcw youngcw Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that using locales + the Actual format would be best.

});

// Add a sheet and set the formula in cell A1
Expand Down
1 change: 1 addition & 0 deletions packages/desktop-client/src/hooks/useTransactionFormulaExecution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ export function useTransactionFormulaExecution(
hfInstance = HyperFormula.buildEmpty({
licenseKey: 'gpl-v3',
localeLang: typeof locale === 'string' ? locale : 'en-US',
dateFormats: ['DD/MM/YYYY', 'YYYY-MM-DD', 'YYYY/MM/DD'],
});

// Add a sheet
Expand Down
2 changes: 1 addition & 1 deletion packages/loot-core/src/server/rules/action.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,7 @@ export class Action {
hfInstance = HyperFormula.buildEmpty({
licenseKey: 'gpl-v3',
language: 'enUS',
dateFormats: ['DD/MM/YYYY', 'YYYY-MM-DD', 'YYYY/MM/DD'],
});

const sheetName = hfInstance.addSheet('Sheet1');
Expand Down Expand Up @@ -336,7 +337,6 @@ export class Action {
}
hfInstance.addNamedExpression(key, cellValue);
}

hfInstance.setCellContents({ sheet: sheetId, col: 0, row: 0 }, [
[formula],
]);
Expand Down
5 changes: 4 additions & 1 deletion packages/loot-core/src/server/rules/formula-action.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,10 @@ describe('Formula-based rule actions', () => {
it('should provide today variable', () => {
const action = new Action('set', 'date', null, {});
const transaction = { date: '2024-01-01' };
const result = action.executeFormulaSync('=today', transaction);
const result = action.executeFormulaSync(
'=TEXT(today,"YYYY-MM-DD")',
transaction,
);

// Should be a date string in YYYY-MM-DD format
expect(typeof result).toBe('string');
Expand Down
6 changes: 6 additions & 0 deletions upcoming-release-notes/7373.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
category: Bugfixes
authors: [youngcw]
---

Fix date variable in rule formulas
Loading