Skip to content

fix: Replace arduino component dependency name#501

Open
Foupi wants to merge 1 commit intoadafruit:masterfrom
Foupi:fix/cmakelists_arduino_dependency
Open

fix: Replace arduino component dependency name#501
Foupi wants to merge 1 commit intoadafruit:masterfrom
Foupi:fix/cmakelists_arduino_dependency

Conversation

@Foupi
Copy link
Copy Markdown

@Foupi Foupi commented Jan 26, 2026

This PR aims to fix build when using this library as an ESP-IDF component.

arduino currently is not recognized as a valid component name in the CMakeLists.txt file ; I replaced it with arduino-esp32.

It is aleady named like this in the Adafruit_BusIO library : https://github.com/adafruit/Adafruit_BusIO/blob/3b8364267c3ee6e16bad91bc2101aefbd5b5915f/CMakeLists.txt#L9

@Foupi
Copy link
Copy Markdown
Author

Foupi commented Jan 26, 2026

Note : I did not really go out of my way to check that this change did not break existing examples. I assumed it wouldn't since BusIO already has this change.

Maybe there should be a test for ESP-IDF integration ; I may add it I manage to make room for it in my schedule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant