fix: Replace arduino component dependency name#501
Open
Foupi wants to merge 1 commit intoadafruit:masterfrom
Open
fix: Replace arduino component dependency name#501Foupi wants to merge 1 commit intoadafruit:masterfrom
Foupi wants to merge 1 commit intoadafruit:masterfrom
Conversation
Author
|
Note : I did not really go out of my way to check that this change did not break existing examples. I assumed it wouldn't since BusIO already has this change. Maybe there should be a test for ESP-IDF integration ; I may add it I manage to make room for it in my schedule. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to fix build when using this library as an ESP-IDF component.
arduinocurrently is not recognized as a valid component name in theCMakeLists.txtfile ; I replaced it witharduino-esp32.It is aleady named like this in the Adafruit_BusIO library : https://github.com/adafruit/Adafruit_BusIO/blob/3b8364267c3ee6e16bad91bc2101aefbd5b5915f/CMakeLists.txt#L9