Add support for 10Mhz clock #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a pin is connected to the hardware reset line then pull it low for a short period, to hold the device in reset, before getting it back high to release the device from reset.
|
Hello 👋 First of all, thank you for your contribution! I'll review the changes and come back to you early next week. |
|
@Stephen-Bath Did you add the support for 25kbps CAN for other oscillator frequencies as well or just the 10MHz? |
|
Just for the 10Mhz. I didn’t want to risk modifying anything not directly related to my change.On 7 Aug 2023, at 18:48, Piotr Adamczyk ***@***.***> wrote:
Did you add the support for 25kbps CAN for other oscillator frequencies as well or just the 10MHz?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all thanks for your work on this library!
I was looking to use your library to support the CAN SPI Click board which uses the MCP2515, however I was initially unable to use it as the board uses a 10Mhz clock which is not supported by your library.
This pull request adds support for 10Mhz clocks.