implement right frozen #3671
Open
implement right frozen #3671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not override frozen to left | right | null, I just add rightFrozen property. It will not break original version.
robert-luoqing
requested review from
amanmahajan7 and
nstepien
as code owners
|
this is a necessary feature |
|
@amanmahajan7 any news on this? |
|
Whats needed to get this across the finish line? willing to put resources on it |
|
Any update on this feature merging? |
amanmahajan7
requested changes
Jul 30, 2025
| @@ -39,6 +39,8 @@ export interface Column<TRow, TSummaryRow = unknown> { | |||
| readonly colSpan?: Maybe<(args: ColSpanArgs<TRow, TSummaryRow>) => Maybe<number>>; | |||
| /** Determines whether column is frozen or not */ | |||
| readonly frozen?: Maybe<boolean>; | |||
| /** Determines whether column is right frozen or not */ | |||
| readonly rightFrozen?: Maybe<boolean>; | |||
There was a problem hiding this comment.
I would rather not add a new prop that can cause conflicts. What happens when both rightFrozen and frozen props are set? We can instead change frozen to boolean | 'left' | 'right'.
| @@ -52,13 +52,15 @@ export function useCalculatedColumns<R, SR>({ | |||
| const defaultResizable = defaultColumnOptions?.resizable ?? false; | |||
| const defaultDraggable = defaultColumnOptions?.draggable ?? false; | |||
|
|
|||
| const { columns, colSpanColumns, lastFrozenColumnIndex, headerRowsCount } = useMemo((): { | |||
| const { columns, colSpanColumns, lastFrozenColumnIndex, rightFrozenColumnCount, headerRowsCount } = useMemo((): { | |||
There was a problem hiding this comment.
All the new functionality needs extensive tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not override frozen to left | right | null, I just add rightFrozen property. It will not break original version.