-
Notifications
You must be signed in to change notification settings - Fork 4
feat(go): add validation suite #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(go): add validation suite #35
Conversation
lidavidm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I locked my account...I'll test later
#42 It seems one of the internal queries needs updating. #43 I think we need to sort the result by ordinal_position. I think this is a known issue with how Snowflake treats timestamp types on ingest. We should just mark this as the "correct" answer for now. I'm not sure where this is coming from. Maybe Snowflake sees very large doubles as Inf? #44 I think this is a bug. |
lidavidm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you fix the float64 and ingest timestamp issues? For float64 maybe change the data being bound, for ingest timestamp just mark it as expected that the result type is different
|
Fixed the float64 and ingest timestamp issues and fixed the driver name too. For float64 binding, it dont seem to accept anything larger than 1.797693e+38. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these coming back as LA time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Snowflake is returning these in the session timezone. I set the session timezone to UTC and removed the LA time overrides.
What's Changed
Setup validation suite and override tests
Closes #6 .
7 tests are failing. Not sure how to handle them. @lidavidm can you take a look? Thanks