Skip to content

Conversation

@davidhcoe
Copy link
Collaborator

@davidhcoe davidhcoe commented Dec 9, 2025

What's Changed

Ports over the current state of https://github.com/apache/arrow-adbc/tree/main/csharp/src/Drivers/Interop/Snowflake, changed the namespace, updated headers and build scripts.

Copy link
Contributor

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For files ported from the Apache repo, we need to keep the original license header and add the attribution text (same as for other files)

@davidhcoe
Copy link
Collaborator Author

For files ported from the Apache repo, we need to keep the original license header and add the attribution text (same as for other files)

I kept going through the pre-commit check until it didn't fail anymore. I would get details like:

Apache RAT Check.........................................................Failed
- hook id: rat
- exit code: 6

Checking licenses for C:\dev\davidhcoe\adbc-drivers-snowflake
Using Apache RAT: C:\Users\davidcoe\AppData\Local\ADBC Driver Foundry\adbc-drivers-dev\Cache\apache-rat-0.16.1.jar
Files missing ADBC Drivers Contributors copyright header:
- csharp/test/Interop/Resources/snowflakeconfig.json
Files that should not have 'This file has been modified' header:
- csharp/src/Interop/Build-SnowflakeDriver.ps1
- csharp/src/Interop/copySnowflakeDriver.sh
- csharp/src/Interop/readme.md
- csharp/test/Interop/Resources/SnowflakeConstraints.sql
- csharp/test/Interop/Resources/SnowflakeData.sql

and that all clears now. Is there something else I need to do?

@lidavidm
Copy link
Contributor

lidavidm commented Dec 9, 2025

I think instead of taking out the 'this file has been modified' part instead we should list the files in /.rat-apache

@lidavidm
Copy link
Contributor

lidavidm commented Dec 9, 2025

(I should update the check to make that clear)

@davidhcoe
Copy link
Collaborator Author

Well, technically speaking, the .cs files have all had their namespace changed, so that is a change. The csharp/src/Interop/Build-SnowflakeDriver.ps1 file is different, and various others to match the namespace. Very few actually copied over directly, but I just followed what was in the pre-commit. Do you want me to make the correct updates then add the "unchanged" ones to .rat-apache?

@lidavidm
Copy link
Contributor

lidavidm commented Dec 9, 2025

If they were copied then modified, they should have the "modified" header. If they were written for this PR, then they can have the regular header. .rat-apache lists ones that were copied then modified. I think the latest commit looks about right

@davidhcoe
Copy link
Collaborator Author

yes.. I think it should be good now.

Comment on lines 1 to 3
# Copyright (c) 2025 ADBC Drivers Contributors
#
# Licensed to the Apache Software Foundation (ASF) under one
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs the 'modified' bit in the header

Comment on lines 3 to 5
Copyright (c) 2025 ADBC Drivers Contributors

Licensed to the Apache Software Foundation (ASF) under one
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here (I guess I need to make the check look for "Licensed to the Apache Software Foundation...")

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines 1 to 4

-- Copyright (c) 2025 ADBC Drivers Contributors
--
-- Licensed to the Apache Software Foundation (ASF) under one
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto here

Comment on lines 1 to 5
<!--

Copyright (c) 2025 ADBC Drivers Contributors

Licensed to the Apache Software Foundation (ASF) under one
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto here

Comment on lines 1 to 4

-- Copyright (c) 2025 ADBC Drivers Contributors
--
-- Licensed to the Apache Software Foundation (ASF) under one
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto here

@lidavidm
Copy link
Contributor

FYI @davidhcoe it seems your Git has no email configured - is this intentional?

Co-authored-by: David Coe <>

@davidhcoe
Copy link
Collaborator Author

FYI @davidhcoe it seems your Git has no email configured - is this intentional?

Co-authored-by: David Coe <>

This account has been used for personal, professional and educational projects, each with separate email accounts, so I just didn't assign one.

@lidavidm lidavidm merged commit 9b601f3 into adbc-drivers:main Dec 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants