Fix incorrect language prefix in menu URLs#1840
Open
leemojiang wants to merge 1 commit intoadityatelange:masterfrom
Open
Fix incorrect language prefix in menu URLs#1840leemojiang wants to merge 1 commit intoadityatelange:masterfrom
leemojiang wants to merge 1 commit intoadityatelange:masterfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
This PR fixes an issue with incorrect language prefix placement in menu URLs when using a
baseURLthat includes a subpath (e.g.,/blog/). Previously, when using multilingual configurations (e.g.,zhanden), thezhlanguage prefix was incorrectly inserted before the baseURL subpath, resulting in URLs like:https://leemojiang.github.io/zh/blog/archives/
Instead of the expected:
https://leemojiang.github.io/blog/zh/archives/
What changed
Detect external links (http://, https://, protocol-relative) and skip Hugo internal URL rewriting for them.
For internal links:
Normalize menu paths by removing a leading /.
Remove the baseURL subpath prefix from menu entries when present (to avoid duplicated /blog).
Rebuild links using site.Home.RelPermalink + menu_path so language prefix and subpath order is always correct.
Keep active menu highlighting based on normalized RelPermalink comparison to avoid false mismatches.
This improves compatibility for multilingual deployments under subpaths (for example, GitHub Pages project sites).
You can see an example of the fixed behavior on my blog: https://leemojiang.github.io/blog/
Was the change discussed in an issue or in the Discussions before?
Yes, this issue is related to #1661, where users reported incorrect URL generation when using a
baseURLwith a subpath and multiple languages. A similar issue is also discussed in another theme #682.PR Checklist