Skip to content

feat: Sidekick library#43

Draft
dylandepass wants to merge 3 commits into
mainfrom
sidekick-library
Draft

feat: Sidekick library#43
dylandepass wants to merge 3 commits into
mainfrom
sidekick-library

Conversation

@dylandepass

@dylandepass dylandepass commented Feb 2, 2024

Copy link
Copy Markdown
Member

Adds sidekick library support

URL for testing:

@aem-code-sync

aem-code-sync Bot commented Feb 2, 2024

Copy link
Copy Markdown

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

const resetAttributeBase = (tag, attr) => {
main.querySelectorAll(`${tag}[${attr}^="./media_"]`).forEach((elem) => {
elem[attr] = new URL(elem.getAttribute(attr), new URL(path, window.location)).href;
elem[attr] = new URL(elem.getAttribute(attr), new URL(path, getOrigin())).href;

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes fragments when running in the library

@aem-code-sync

aem-code-sync Bot commented Feb 2, 2024

Copy link
Copy Markdown
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@fkakatie fkakatie marked this pull request as draft February 12, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant