Skip to content

Conversation

@ujjwal5
Copy link

@ujjwal5 ujjwal5 commented Oct 4, 2024

…change]

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #409

Test URLs:

@ujjwal5
Copy link
Author

ujjwal5 commented Oct 4, 2024

Currently, the styles applied to a 'fragment' block are lost when the HTML is replaced. Ideally, any styles defined for the block should be retained. Additionally, the HTML structure of the fragment block is different from other blocks. Normally, the structure follows the pattern: container → wrapper → block. However, for the fragment block, it follows container → wrapper, omitting the block level.

HTML structure with existing code:

<div class="section fragment-container" data-section-status="loaded" style="">
   <div class="fragment-wrapper">
      <div class="section" data-section-status="loaded" data-key="value" style="">
         <div class="default-content-wrapper">
            <p>Would you like to see what you can discover about your family?</p>
            <ul>
               <li>Yes</li>
               <li>No</li>
               <li>I’m not sure</li>
            </ul>
            <p class="button-container"><a href="https://www.ancestry.com/onboarding/lop/questionnaire/intro" title="Continue" class="button">Continue</a></p>
            <p class="button-container"><a href="#" title="Dismiss" class="button">Dismiss</a></p>
         </div>
      </div>
      <div class="section columns-container" data-section-status="loaded" data-key5="value5" style="">
         <div class="default-content-wrapper">
            <p>Another section starting here.</p>
         </div>
         <div class="columns-wrapper">
            <div class="columns style-class block columns-2-cols" data-block-name="columns" data-block-status="loaded">
               <div class="bg-color-1">
                  <div class="text-content">
                     <p>key10</p>
                  </div>
                  <div class="text-content">
                     <p>value10</p>
                  </div>
               </div>
            </div>
         </div>
      </div>
   </div>
</div>

Proposed HTML structure with fixed issues:

<div class="section fragment-container" data-section-status="loaded" style="">
   <div class="fragment-wrapper">
      <div class="fragment animate block" data-block-name="fragment" data-block-status="loaded">
         <div class="section" data-section-status="loaded" data-key="value" style="">
            <div class="default-content-wrapper">
               <p>Would you like to see what you can discover about your family?</p>
               <ul>
                  <li>Yes</li>
                  <li>No</li>
                  <li>I’m not sure</li>
               </ul>
               <p class="button-container"><a href="https://www.ancestry.com/onboarding/lop/questionnaire/intro" title="Continue" class="button">Continue</a></p>
               <p class="button-container"><a href="#" title="Dismiss" class="button">Dismiss</a></p>
            </div>
         </div>
         <div class="section columns-container" data-section-status="loaded" data-key5="value5" style="">
            <div class="default-content-wrapper">
               <p>Another section starting here.</p>
            </div>
            <div class="columns-wrapper">
               <div class="columns style-class block columns-2-cols" data-block-name="columns" data-block-status="loaded">
                  <div class="bg-color-1">
                     <div class="text-content">
                        <p>key10</p>
                     </div>
                     <div class="text-content">
                        <p>value10</p>
                     </div>
                  </div>
               </div>
            </div>
         </div>
      </div>
   </div>
</div>

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 4, 2024

Page Scores Audits Google
📱 /en/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /en/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@kptdobe
Copy link
Contributor

kptdobe commented Nov 18, 2024

This PR removes the content of fstab.yaml. Please create a proper PR if this is something to be reviewed.

@kptdobe kptdobe closed this Nov 18, 2024
@ujjwal5
Copy link
Author

ujjwal5 commented Nov 19, 2024

@kptdobe I had raised this PR almost a month ago, but while testing Config Service APIs on the same repo, they were inadvertently included in this PR. I’ve now raised a new PR (#434) addressing the attached issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fragment block should retain authored classes

2 participants