-
Notifications
You must be signed in to change notification settings - Fork 23
Data-navigator: Enabling navigable chart elements with alt text #483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
frankelavsky
wants to merge
37
commits into
adobe:main
Choose a base branch
from
frankelavsky:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 10 commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
b6336af
add data-navigator dependency
frankelavsky 500791e
add basic dimension navigation to charts
frankelavsky e1e6124
load view into Navigator, remove excess comments
frankelavsky be94d24
add rendering property initialization for navigation
frankelavsky 5289911
use latest data-navigator, with dimension compression
frankelavsky 6b090c3
add spatial properties and semantics for dimensions and divisions
frankelavsky fdea7db
reduce nav dimensions to 2, limit nav to bar
frankelavsky 62da48b
add conditional render of navigator if nav layers exist
frankelavsky bb18dc0
add navigation event callback to navigator
frankelavsky c4d8c7a
emit valid vegaId within nav event callback
frankelavsky 0b2eb42
convert navigation to generics for up, down, left, right
frankelavsky 6044ba9
fix placement for stacked bar divisions
frankelavsky cfa72ba
fix focus indication location for dodged bar
frankelavsky 0588cce
make function to set child spatial properties generic
frankelavsky 7a779a9
feat: add signals and styling for focus
marshallpete 02cdad3
fix: remove debug
marshallpete c6872f3
feat: add focus to stacked bar dimensions
marshallpete 796e4d1
fix nav element location between dodge, stack, and regular bar
frankelavsky ed3982a
remove redundant focus indicator on nav element
frankelavsky 7855053
add 2 new elements for mobile fallback
frankelavsky b28b36d
fix: stop pointer-events on navigation nodes
frankelavsky 6e842c4
remove console log
frankelavsky 589fb35
use divs for better mobile detection, improve division labels
frankelavsky a6caf04
remove console log
frankelavsky 7aa9ccc
fix: navigation now maintains direction at childmost level
frankelavsky dd90d05
fix: use the same dimension behavior for all navigation
frankelavsky 2cf6f15
add spatial names for navigation constants
frankelavsky 1e896a4
refactor: build navigation downstream using spec
frankelavsky 5ee8183
remove unused logs
frankelavsky 3cbcc7e
fix: typo on image role semantics
frankelavsky e4e5a7f
fix: add state for mobile fallback elements
frankelavsky 9b21c83
clean up commented blocks
frankelavsky 2f601eb
fix: remove mobile fallback elements
frankelavsky bb7afca
hide vega chart from screen readers
frankelavsky f4af887
fix: hide entry button until focused
frankelavsky 9ba7cda
fix: remove repeated id usage from navigator
frankelavsky eb0b982
feat: add blur handling to navigation events
frankelavsky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update for @marshallpete:
I solved our valid ID issue and am emitting events from the Navigator. (This function in RSCChart is passed down to our Navigator and is where we want to now call a function to set a signal.)
So basically, we now just need to create a new signal and manipulate it here.
The
NavigationEventtype sends the following:This allows us to turn our soon-to-be-made focus signal on/off, activate a "selection" signal (and run functions related to selection, if those exist?), as well as watch for
enter,exit, andhelpevents (which I am sure will matter in the future, but right now probably don't matter).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! I've cleared my schedule to work on this today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woohoo! Awesome. Stoked to see what you assemble. Let me know if you have questions or anything, otherwise I'll wait to see how I can build off of this tomorrow morning.
Also as a note: "focused" has 1 s (not "focussed").
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fun fact about me. I exclusively commit code with typos. 😂