Skip to content

Wagtail 2 fixes #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Wagtail 2 fixes #2

wants to merge 7 commits into from

Conversation

philgyford
Copy link

Some fixes to get this working on Wagtail 2 (I'm using Wagtail 2.4 and Django 2.1).

  • Fix imports that broke from Django 2.0+ (the fixes should still work with older versions of Django)
  • Fix imports that broke from Wagtail 2.0+ (same)
  • Replace broken use of gravatar template tag (which is not included) with xtd_comment_gravtar_url
  • Fix layout of avatars in Wagtail admin (they were too big for current Wagtail)

Also:

  • Allow the use of a custom django-comments-xtd comment model using the COMMENTS_XTD_MODEL setting
  • Use relative dates for the list of comments in Wagtail admin, to be consistent with other admin lists

@philgyford
Handle failed import of django.core.urlresolvers
72ecc0d 
No longer present from Django 2.0
@philgyford
Fix broken import of wagtail Page model
74c7c9e
@philgyford
Fix broken wagtail imports in hooks
e69038d
@philgyford
Add back legacy wagtail imports
98936d9 
So it should still work for those using Wagtail < 2.0 as well as those
on Wagtail 2.0+
@philgyford
Allow customising of the django-comments-xtd comment model
d47fcb7 
Instead of importing `django_comments_xtd.models.XtdComment`, use
the `django_comments_xtd.get_model()` method to get the model instead.
@philgyford
Fix use of gravatar template tags
da2d6b9 
The `comments/_list_explore.html` tried to load `gravtar` template
tags which do not exist, unless they're installed/created separately.

Now use the [`xtd_comment_gravatar_url`](https://django-comments-xtd.readthedocs.io/en/latest/templatetags.html?highlight=template%20tags#filter-xtd-comment-gravatar-url) that's
build into django-comments-xtd instead.
@philgyford
Use relative dates for admin list of comments
9f45b9a 
To be consistent with other Wagtail admin pages
@philgyford
Copy link
Author

This continues to work with Wagtail 2.5 and Django 2.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@philgyford