add cmake build #61
Open
add cmake build #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initial cmake build, and some readme ...
The custom target for submodules is a bit strange for a cmake build, but tries to immitate (somewhat) the original Makefile ...
It might be better to not have that as a target, and just include in instructions that you should update submodules, or there might be a better way to setup the custom target ... I couldn't find one. You may execute the process as part of configuring the build, and then make clean && make would not invoke the submodules target every time, but it seemed somewhat simpler to do it this way so install is "make -jX install".