Release 1.3.0 by khushboo-singhvi · Pull Request #124 · adyen-examples/adyen-magento2-hyva

khushboo-singhvi · 2025-07-11T10:58:18Z

Summary

Tested scenarios

Fixed issue:

Co-authored-by: Can Demiralp <can.demiralp@adyen.com>

…112) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

#107) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Can Demiralp <ecandemiralp@gmail.com>

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Can Demiralp <ecandemiralp@gmail.com>

* [ECP-9721] Enable explicit CodeQL configuration * [ECP-9721] Adjust Renovate stability days * Revert "[ECP-9721] Enable explicit CodeQL configuration" This reverts commit 54a6054. * [ECP-9721] Update workflow permissions

@todo

* CSP migration This will run several tools to optimize your code, find more about CSP Read our documentation for [theme](https://docs.hyva.io/hyva-themes/writing-code/csp/index.html) and [checkout](https://docs.hyva.io/checkout/hyva-checkout/devdocs/csp/index.html) changes - @todo! means **work todo**, please review - @done! means **no work todo**, just informing about the change - requirement `hyva-themes/magento2-theme-module` (`^1.3.11`) @done! - requirement `hyva-themes/magento2-hyva-checkout` (`^1.3`) @done! * I left a syntax error :sad: - fixed now * Make the overwritten Methodlist compatible with the original file * this file is fully overwritten, which makes it impossible if Hyva will add a new feature, or of another payment method is listening for the original method. * Make sure the MethodList is forward compatible with future updates * I removed a comma last time, then I removed a comma to many * Use a global boot event to unload earlier loads * Don't rely on the window action but make use of alpine * Use alpine init instead of window event * We will no longer depend on the payment:method:activate event * Use alpine for cc-vault * Add checkout validation to global scope * gracefully decline * Remove dependency on eventListeners in favor of alpinejs --------- Co-authored-by: Can Demiralp <can.demiralp@adyen.com>

#119) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Can Demiralp <can.demiralp@adyen.com>

…117) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Adjust Sonarcube action version * Update Magento version to support CSP patch

gemini-code-assist

Summary of Changes

Hello @khushboo-singhvi, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request represents a consolidated release, bundling various updates and improvements. The primary focus of these changes is to enhance Content Security Policy (CSP) compliance for Adyen payment methods within the Hyva Checkout, alongside crucial dependency updates and general code refactoring.

Highlights

Enhanced CSP Compliance: A significant refactoring has been implemented to improve Content Security Policy (CSP) compliance for Adyen payment methods. This involves migrating inline JavaScript from payment method templates into dedicated, external .phtml files, which are then registered via the Hyva CSP mechanism.
Dependency Updates: Key dependencies have been updated, including Hyva Checkout (^1.1 to ^1.3), Elasticsearch (7.17.13 to 7.17.28), and Playwright (v1.50.1 to v1.53.2), ensuring compatibility and leveraging the latest features and security patches.
Code Refactoring and Alignment: The Magewire/Payment/MethodList.php class has been refactored to extend Hyva Checkout's base MethodList class, reducing boilerplate and improving maintainability. Alpine.js integration for payment method rendering has also been streamlined.
Renovate Configuration Update: The renovate.json configuration has been adjusted to reduce the minimumReleaseAge for dependency updates from 30 to 21 days, potentially allowing for faster integration of new versions.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a significant refactoring of the Adyen payment method rendering for Hyvä checkout, moving inline JavaScript into separate, CSP-compliant template files using Alpine.js, which improves maintainability and security. However, several critical and high-severity issues need to be addressed, including missing x-init calls in Alpine.js components and empty catch blocks.

gemini-code-assist · 2025-07-11T11:01:21Z

view/frontend/templates/payment/method-renderer/adyen-cc-method.phtml

+    <div x-data="adyenPaymentMethodRendererAdyenCcMethod"
+         data-enable-store-details="<?= $escaper->escapeHtmlAttr($magewire->getConfiguration()->isCCEnableStoreDetails($magewire->userIsGuest())) ?>"
+         data-has-holder-name="<?= $escaper->escapeHtmlAttr($magewire->getConfiguration()->getValue('adyen/hasHolderName')) ?>"
+         data-holder-name-required="<?= $escaper->escapeHtmlAttr($magewire->getConfiguration()->getValue('adyen/holderNameRequired')) ?>"
+         data-formatted-installments-json="<?= $escaper->escapeHtmlAttr($magewire->getFormattedInstallments()) ?>"
+         data-title="<?= $escaper->escapeHtmlAttr($magewire->getConfiguration()->getValue('adyenCc/title')) ?>"
+    ></div>


The Alpine.js component adyenPaymentMethodRendererAdyenCcMethod is defined, but its init() method is never called. This will prevent the payment method from initializing correctly. You should call it using x-init="init()".

<div x-data="adyenPaymentMethodRendererAdyenCcMethod" x-init="init()" data-enable-store-details="<?= $escaper->escapeHtmlAttr($magewire->getConfiguration()->isCCEnableStoreDetails($magewire->userIsGuest())) ?>" data-has-holder-name="<?= $escaper->escapeHtmlAttr($magewire->getConfiguration()->getValue('adyen/hasHolderName')) ?>" data-holder-name-required="<?= $escaper->escapeHtmlAttr($magewire->getConfiguration()->getValue('adyen/holderNameRequired')) ?>" data-formatted-installments-json="<?= $escaper->escapeHtmlAttr($magewire->getFormattedInstallments()) ?>" data-title="<?= $escaper->escapeHtmlAttr($magewire->getConfiguration()->getValue('adyenCc/title')) ?>" ></div>

gemini-code-assist · 2025-07-11T11:01:21Z

view/frontend/templates/payment/method-renderer/adyen-default-method.phtml

+    <div x-data="adyenPaymentMethodRendererAdyenDefaultMethod"
+         data-container-name="<?= $escaper->escapeHtmlAttr($magewire->getContainerName()) ?>"
+         data-method-code="<?= $escaper->escapeHtmlAttr($magewire->getMethodCode()) ?>"
+    ></div>


The Alpine.js component adyenPaymentMethodRendererAdyenDefaultMethod is defined, but its init() method is never called. This will prevent the payment method from initializing correctly. You should call it using x-init="init()".

<div x-data="adyenPaymentMethodRendererAdyenDefaultMethod" x-init="init()" data-container-name="<?= $escaper->escapeHtmlAttr($magewire->getContainerName()) ?>" data-method-code="<?= $escaper->escapeHtmlAttr($magewire->getMethodCode()) ?>" ></div>

gemini-code-assist · 2025-07-11T11:01:21Z

view/frontend/templates/payment/method-renderer/adyen-paypal-method.phtml

-            }
-        }
-    </script>
+    <div x-data="adyenPaymentMethodRendererAdyenPaypalMethod"></div>


The Alpine.js component adyenPaymentMethodRendererAdyenPaypalMethod is defined, but its init() method is never called. This will prevent the payment method from initializing correctly. You should call it using x-init="init()".

<div x-data="adyenPaymentMethodRendererAdyenPaypalMethod" x-init="init()"></div>

gemini-code-assist · 2025-07-11T11:01:21Z

view/frontend/templates/payment/method-renderer/adyen-affirm-method.phtml

+    <div x-data="adyenPaymentMethodRendererAdyenAffirmMethod"
+         data-container-name="<?= $escaper->escapeHtmlAttr($magewire->getContainerName()) ?>"
+         data-method-code="<?= $escaper->escapeHtmlAttr($magewire->getMethodCode()) ?>"
+    ></div>


The Alpine.js component adyenPaymentMethodRendererAdyenAffirmMethod is defined, but its init() method is never called. This will prevent the payment method from initializing correctly. You should call it using x-init="init()".

<div x-data="adyenPaymentMethodRendererAdyenAffirmMethod" x-init="init()" data-container-name="<?= $escaper->escapeHtmlAttr($magewire->getContainerName()) ?>" data-method-code="<?= $escaper->escapeHtmlAttr($magewire->getMethodCode()) ?>" ></div>

gemini-code-assist · 2025-07-11T11:01:21Z

view/frontend/templates/payment/method-renderer/adyen-googlepay-method.phtml

-            }
-        }
-    </script>
+    <div x-data="adyenPaymentMethodRendererAdyenGooglepayMethod"></div>


The Alpine.js component adyenPaymentMethodRendererAdyenGooglepayMethod is defined, but its init() method is never called. This will prevent the payment method from initializing correctly. You should call it using x-init="init()".

<div x-data="adyenPaymentMethodRendererAdyenGooglepayMethod" x-init="init()"></div>

gemini-code-assist · 2025-07-11T11:01:23Z

view/frontend/templates/payment/method-renderer/adyen-amazonpay-method-csp-js.phtml

+        } catch (e) {
+        }


This empty catch block suppresses errors, which can make debugging very difficult. It's best practice to at least log the error to the console.

} catch (e) { console.error('Error initializing Adyen AmazonPay method:', e); }

gemini-code-assist · 2025-07-11T11:01:23Z

view/frontend/templates/payment/method-renderer/adyen-paypal-method-csp-js.phtml

+            } catch (e) {
+            }


This empty catch block suppresses errors, which can make debugging very difficult. It's best practice to at least log the error to the console.

} catch (e) { console.error('Error initializing Adyen PayPal method:', e); }

gemini-code-assist · 2025-07-11T11:01:23Z

view/frontend/templates/payment/method-renderer/adyen-affirm-method-csp-js.phtml

+        } catch (e) {
+        }


This empty catch block suppresses errors, which can make debugging very difficult. It's best practice to at least log the error to the console.

} catch (e) { console.error('Error initializing Adyen Affirm method:', e); }

gemini-code-assist · 2025-07-11T11:01:23Z

composer.json

+      "magento/composer-dependency-version-audit-plugin": true,
+      "dealerdirect/phpcodesniffer-composer-installer": true
+    }
+  }


It's a common convention for text files, including JSON files, to end with a newline character. Some tools and systems might not process the file correctly without it.

gemini-code-assist · 2025-07-11T11:01:23Z

view/frontend/templates/payment/method-renderer/adyen-facilypay-method-csp-js.phtml

+                    window.AdyenPaymentHandler = methodHandler;
+
+                    if (wire.get('requiresShipping')) {
+                        methodHandler.renderMessage('Please select shipping method.');


This string is not translatable. For internationalization, it should be wrapped in Magento's JavaScript translation function.

methodHandler.renderMessage("<?= $escaper->escapeJs(__('Please select shipping method.')) ?>");

…ght-1.x chore(deps): update mcr.microsoft.com/playwright docker tag to v1.54.0

candemiralp and others added 10 commits February 20, 2025 16:28

[ECP-9628] Implement timeout for workflows (#105)

c1d9100

Co-authored-by: Can Demiralp <can.demiralp@adyen.com>

chore(deps): update dependency squizlabs/php_codesniffer to ~3.12.0 (#…

4ce03a4

…112) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

chore(deps): update mcr.microsoft.com/playwright docker tag to v1.52.0 (

4c6ac8c

#107) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Can Demiralp <ecandemiralp@gmail.com>

chore(deps): update elasticsearch docker tag to v7.17.27 (#106)

2014c73

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Can Demiralp <ecandemiralp@gmail.com>

chore(deps): update mcr.microsoft.com/playwright docker tag to v1.53.2 (

26174b2

#119) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

chore(deps): update elasticsearch docker tag to v7.17.28 (#114)

649ddfb

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Can Demiralp <can.demiralp@adyen.com>

chore(deps): update dependency squizlabs/php_codesniffer to ~3.13.0 (#…

c9abe07

…117) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Use new version of the SonarCube action (#118)

fa62f1f

* Adjust Sonarcube action version * Update Magento version to support CSP patch

khushboo-singhvi requested a review from a team as a code owner July 11, 2025 10:58

khushboo-singhvi had a problem deploying to internal July 11, 2025 10:58 — with GitHub Actions Failure

khushboo-singhvi had a problem deploying to internal July 11, 2025 10:58 — with GitHub Actions Error

khushboo-singhvi had a problem deploying to internal July 11, 2025 10:58 — with GitHub Actions Failure

gemini-code-assist bot reviewed Jul 11, 2025

View reviewed changes

khushboo-singhvi changed the title ~~Release 1.x.x~~ Release 1.3.0 Jul 11, 2025

Version Bump 1.3.0

b44a19b

khushboo-singhvi had a problem deploying to internal July 11, 2025 11:11 — with GitHub Actions Failure

khushboo-singhvi had a problem deploying to internal July 11, 2025 11:11 — with GitHub Actions Error

khushboo-singhvi had a problem deploying to internal July 11, 2025 11:11 — with GitHub Actions Failure

renovate bot and others added 2 commits July 11, 2025 11:11

chore(deps): update mcr.microsoft.com/playwright docker tag to v1.54.0

b8c5dc4

Merge branch 'main' into develop

2182b55

khushboo-singhvi had a problem deploying to internal July 11, 2025 11:12 — with GitHub Actions Failure

khushboo-singhvi had a problem deploying to internal July 11, 2025 11:12 — with GitHub Actions Error

khushboo-singhvi had a problem deploying to internal July 11, 2025 11:12 — with GitHub Actions Failure

khushboo-singhvi added 2 commits July 11, 2025 13:12

Merge branch 'develop' into renovate/mcr.microsoft.com-playwright-1.x

806ca2d

Merge pull request #123 from Adyen/renovate/mcr.microsoft.com-playwri…

b0b8d09

…ght-1.x chore(deps): update mcr.microsoft.com/playwright docker tag to v1.54.0

khushboo-singhvi had a problem deploying to internal July 11, 2025 11:27 — with GitHub Actions Failure

khushboo-singhvi had a problem deploying to internal July 11, 2025 11:27 — with GitHub Actions Error

khushboo-singhvi had a problem deploying to internal July 11, 2025 11:27 — with GitHub Actions Failure

candemiralp approved these changes Jul 11, 2025

View reviewed changes

khushboo-singhvi merged commit 4d44bd3 into main Jul 11, 2025
6 of 9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 1.3.0#124

Release 1.3.0#124
khushboo-singhvi merged 15 commits intomainfrom
develop

khushboo-singhvi commented Jul 11, 2025 •

edited

Loading

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Jul 11, 2025

Uh oh!

gemini-code-assist bot Jul 11, 2025

Uh oh!

gemini-code-assist bot Jul 11, 2025

Uh oh!

gemini-code-assist bot Jul 11, 2025

Uh oh!

gemini-code-assist bot Jul 11, 2025

Uh oh!

gemini-code-assist bot Jul 11, 2025

Uh oh!

gemini-code-assist bot Jul 11, 2025

Uh oh!

gemini-code-assist bot Jul 11, 2025

Uh oh!

gemini-code-assist bot Jul 11, 2025

Uh oh!

gemini-code-assist bot Jul 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

khushboo-singhvi commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Tested scenarios

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

khushboo-singhvi commented Jul 11, 2025 •

edited

Loading