Handle when the passed value is a Numeric value

[eng-Abdurhman]

When the passed value is a Numeric value, then we get an exception 👇
=> NoMethodError: undefined method "to_date" for 444:Integer

So, this PR is to handle that case!

---

@adzap I hope you like this tiny PR and merge it.

Regards 🎉

[tagliala]

Can you add a failing spec?

At the moment I do not understand how it is possible that a Numeric value passes !value.respond_to?(:to_time)

pry(main)> ValidatesTimeliness::VERSION
=> "7.0.0.beta1"

pry(main)> String.method_defined?(:to_time)
=> true
pry(main)> Numeric.method_defined?(:to_time)
=> false

[eng-Abdurhman]

@tagliala 👇

# String
pry(main)> "444".respond_to?(:to_time)
=> true
pry(main)> "444".respond_to?(:to_date)
=> true

# Integer
pry(main)> 444.respond_to?(:to_time)
=> true
pry(main)> 444.respond_to?(:to_date)
=> false

[adzap]

Which would mean this guard would still fail, because the value is actually a string.

>> "444.0".is_a?(Numeric)
false

[adzap]

But as @tagliala said. we'll need a failing spec for this. It is not clear how this occurs.

[tagliala]

The only thing that I can think of is that Numeric has been enhanced with to_time by another library, but that same gem does not define to_date. However, even in this use case that would fail the next line when methods like acts_like?(:time) are invoked. This is why a reduced failing test case would help

[eng-Abdurhman]

@adzap @tagliala
The condition in line #13 just check whether the passed value responds to "to_time" method or not.
whereas the issue is in line #20 while calling "to_date" method not "to_time"!

The Numeric values are responds to "to_time" but not "to_date".

[eng-Abdurhman]

Example:
# app/models/item.rb

validates_date :expire_date

# console:

> item = Item.new(expire_date: 444)
> item.valid?
NoMethodError: undefined method `to_date' for 444:Integer

[tagliala]

Hi, thanks for the clarification.

The Numeric values are responds to "to_time" but not "to_date".

This is the part that does not sound.

Is there any third party library defining to_time on Numeric elements? Can you check where to_time is defined?

I've setup a pretty basic application at https://github.com/diowa/ruby3-rails7-bootstrap-heroku/tree/validates-timeliness

> 444.respond_to?(:to_time)
=> false
[2] pry(main)> Item.new(expire_date: 444).valid?
=> false

However... @adzap probably there could be a better detection if the timeliness helpers are available on the given value. This can also improve third-party compatibility