Skip to content

fix: correct hero structure and strip strong from headings #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fkakatie merged 1 commit into from
Jun 25, 2026
Merged

fix: correct hero structure and strip strong from headings #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
helix-importer-ui
*.min.js
*.min.js
tools/import
20 changes: 10 additions & 10 deletions tools/import/transform-page.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,25 +116,25 @@ function heroBlock($t) {
const { src, alt } = firstImg($t);
const cta = teaserCTA($t);
const ctaHtml = cta && cta.text
? `<p><a href="${cta.href}"><strong>${cta.text}</strong></a></p>` : "";
return `<div class="hero"><div><div>${pic(src, alt)}<h1><strong>${h}</strong></h1>${ctaHtml}</div></div></div>`;
? `<p><a href="${cta.href}"><strong><em>${cta.text}</em></strong></a></p>` : "";
return `<div class="hero"><div><div>${pic(src, alt)}</div><div><h1>${h}</h1>${ctaHtml}</div></div></div>`;
}

function bannerBlock($t) {
function teaserHeroBlock($t) {
const h = $t.find(".teaserHeading").first().text().trim();
const { src, alt } = firstImg($t);
const cta = teaserCTA($t);
const ctaHtml = cta && cta.text
? `<p><a href="${cta.href}"><strong>${cta.text}</strong></a></p>` : "";
return `<div class="banner"><div><div><h2><strong>${h}</strong></h2>${parasHtml(teaserParas($t))}${ctaHtml}</div><div>${pic(src, alt)}</div></div></div>`;
return `<div class="hero"><div><div><h2>${h}</h2>${parasHtml(teaserParas($t))}${ctaHtml}</div><div>${pic(src, alt)}</div></div></div>`;
}

// One tile -> one card row (image cell + text cell).
function tileRow($t) {
const h = $t.find(".teaserHeading").first().text().trim();
const { src, alt } = firstImg($t);
const cta = teaserCTA($t);
const parts = [`<h3><strong>${h}</strong></h3>`, parasHtml(teaserParas($t))];
const parts = [`<h3>${h}</h3>`, parasHtml(teaserParas($t))];
if (cta && cta.text) parts.push(`<p><a href="${cta.href}">${cta.text}</a></p>`);
return `<div><div>${pic(src, alt)}</div><div>${parts.join("")}</div></div>`;
}
Expand All @@ -156,7 +156,7 @@ function listCardsBlock($list) {
const href = https(a.attr("href"));
if (!name && !src && !href) return; // skip empty placeholder items
const text = $li.find(".list__item-cta, .list__readmore").first().text().trim() || "Learn More";
const parts = [`<h3><strong>${name}</strong></h3>`];
const parts = [`<h3>${name}</h3>`];
if (desc) parts.push(`<p>${desc}</p>`);
if (href) parts.push(`<p><a href="${href}">${text}</a></p>`);
rows.push(`<div><div>${pic(src, alt)}</div><div>${parts.join("")}</div></div>`);
Expand Down Expand Up @@ -231,7 +231,7 @@ function listBlock($list, variant) {

if (hasImages) {
const rows = items.map((x) => {
const parts = [`<h3><strong>${x.name}</strong></h3>`];
const parts = [`<h3>${x.name}</h3>`];
if (x.desc) parts.push(`<p>${x.desc}</p>`);
if (x.href) parts.push(`<p><a href="${x.href}">Learn More</a></p>`);
return `<div><div>${x.img ? pic(x.img, x.name) : ""}</div><div>${parts.join("")}</div></div>`;
Expand Down Expand Up @@ -265,7 +265,7 @@ function defaultContent($el, type) {
if (!hd.length) return "";
const txt = hd.text().trim();
if (!txt) return "";
return `<${hd[0].tagName}><strong>${txt}</strong></${hd[0].tagName}>`;
return `<${hd[0].tagName}>${txt}</${hd[0].tagName}>`;
}
// texteditor / text -> its rte paragraphs
const box = $el.find(".cmp-text").first();
Expand Down Expand Up @@ -295,7 +295,7 @@ function metadataBlock() {

// text cell shared by banner / columns / carousel (heading + paragraphs + CTA)
function bannerCell(h, paras, cta) {
const parts = [`<h2><strong>${h}</strong></h2>`, parasHtml(paras)];
const parts = [`<h2>${h}</h2>`, parasHtml(paras)];
if (cta && cta.text) parts.push(`<p><a href="${cta.href}"><strong>${cta.text}</strong></a></p>`);
return parts.join("");
}
Expand Down Expand Up @@ -575,7 +575,7 @@ for (const item of comps) {
if (fragLink) { cur().push(fragLink); continue; }
switch (type) {
case "hero": cur().push(heroBlock($el)); break;
case "banner": cur().push(bannerBlock($el)); break;
case "banner": cur().push(teaserHeroBlock($el)); break;
case "carousel": cur().push(carouselBlock($el)); break;
case "accordion": cur().push(accordionBlock($el)); break;
case "tabs": cur().push(tabsBlock($el)); break;
Expand Down