feat: remove empty properties from etcd-cluster spec to avoid ArgoCD drifting

[apenen]

ArgoCD keeps detecting pending changes because Kubernetes omits empty fields on apply. Removing these fields from the spec prevents unnecessary diffs.

Summary by CodeRabbit

• Schema Updates
  • Enhanced etcd-operator CRD to allow greater flexibility in pod template configuration while preserving essential structural requirements.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Removed an empty properties: {} constraint from the spec.podTemplate.spec schema in the etcd-cluster CRD, allowing flexible property definitions while maintaining existing required field structures like containers.

Changes

Cohort / File(s)	Summary
CRD Schema Loosening charts/etcd-operator/crds/etcd-cluster.yaml	Removed empty properties map from spec.podTemplate.spec in OpenAPIV3Schema, permitting arbitrary properties instead of explicitly restricting to none while preserving required field constraints

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

• Verify the schema loosening is intentional and won't inadvertently accept unwanted properties
• Confirm this aligns with intended podTemplate flexibility

Poem

🐰 A constraint removed, the schema breathes free,
The empty box opens for properties to be,
No more locked down, just flexible and wide,
The podTemplate spec now takes the tide! 🌊

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: removing empty properties from the etcd-cluster spec to resolve ArgoCD drifting issues, which matches the PR's core objective.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6537618 and 0570ab0.

📒 Files selected for processing (1)

• charts/etcd-operator/crds/etcd-cluster.yaml (0 hunks)

💤 Files with no reviewable changes (1)

• charts/etcd-operator/crds/etcd-cluster.yaml

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sircthulhu]

Hi, @apenen! This change will be overriden by commands

make manifests
make helm-crd-copy

So changes need to be made to api/v1alpha1/etcdcluster_types.go