Skip to content

Conversation

@earth2marsh
Copy link
Contributor

@earth2marsh earth2marsh commented Aug 6, 2025

While our link was using the numeric slug, the link text was using a pattern that resulted in a 404. This switches to use the numeric slug.

🍱 Types of changes

What types of changes does your code introduce to AEP? Put an x in the boxes
that apply

  • Enhancement
  • New proposal
  • Migrated from google.aip.dev
  • Chore / Quick Fix

📋 Your checklist for this pull request

Please review the AEP Style and Guidance for
contributing to this repository.

General

While our link was using the numeric slug, the link text was using a pattern that resulted in a 404. This switches to use the numeric slug.
@earth2marsh earth2marsh requested a review from a team as a code owner August 6, 2025 22:02
@earth2marsh
Copy link
Contributor Author

@rambleraptor , I think we moved to numeric slugs without a text-based alias? All I know is that the guidance was suggesting a text-based URL that was resulting in 404s.

@earth2marsh
Copy link
Contributor Author

earth2marsh commented Aug 6, 2025

Hmm, if this change is correct, than I think perhaps https://aep.dev/tooling/linter/rules/0162/ may need an update, too?

I see this guidance does still refer to word-based slugs, so possibly that deserves attention?

@rambleraptor
Copy link
Member

@toumorokoshi

I think we're trying to use the non-numeric slugs. Both of them should work regardless.

@rambleraptor
Copy link
Member

@rofrankel too

@toumorokoshi
Copy link
Member

I think in this particular case we shouldn't update those - that should probably always point at not-precdent in case that aep is updated.

But those are examples, correct? so really it comes down to whether the linter accepts them (I presume it does).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants