Add support for io_uring with Netty 4.2.1.Final #437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netty has finally added io_uring support as part of the 4.2 release. In this update, they've changed the EventLoop class hierarchy, deprecating Epoll/KQueue/Nio EventLoopGroup and replacing it with Multi/SingleThreadIoEventLoopGroup composed of IoHandlerFactory, which defines the event framework. No IOURingEventLoopGroup was ever added. NettyEventLoops needs to adopt a new approach to deciding which EventLoopType we are using. Using isIoType(Handler) seems like a reasonable way to do this. I've also removed usages of the deprecated EventLoopGroup classes and replaced them with the new way of doing things.
|
We will merge this pull request when we upgrade to netty 4.2. |
|
The snyk pull requests for Netty 4.2 were not triggered by a security vulnerability. We will be staying on the Netty 4.1.X branch for the time being. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netty has finally added io_uring support as part of the 4.2 release. In this update, they've changed the EventLooGroup class hierarchy, deprecating Epoll/KQueue/Nio EventLoopGroup and replacing it with Multi/SingleThreadIoEventLoopGroup composed of IoHandlerFactory, which defines the io event framework. No IOURingEventLoopGroup was ever added.
NettyEventLoopsneeds to adopt a new approach to deciding whichEventLoopTypeto use. UsingIoEventLoopGroup.isIoType(Handler)seems like a reasonable way to do this.I've also removed the use of the deprecated EventLoopGroup classes and replaced them with the new method.
Without this PR you'll get
AerospikeException("Unexpected EventLoopGroup")when trying to use netty with io_uring.