INFRA-189: build info in build step #53
Open
+302
−160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs(workflows): update README and entrypoint.sh for build info aggregation fix(workflows): correct script value syntax
fix(workflows): add debugging output to reusable execute-build workflow
…ctly fix(workflows): need command substitution for literal spec
…te-build-info workflow
…amed test(workflows): add debug output for AQL search response in entrypoint script
…ck_build_exists function
…and artifact naming conventions
…collection / git info
arrowplum
force-pushed
the
feature/INFRA-189-build-info-in-build-step
branch
from
3e65380 to
1f7cd47
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR implements build info aggregation in the build step as part of INFRA-189, enabling JFrog build-info collection during the build process and creating a hierarchical build-info structure in the deploy step.
- Refactors
build-versionparameter tobuild-idacross all workflows for consistency - Adds build-info publishing capability to the execute-build workflow
- Implements hierarchical build-info aggregation in deploy-artifacts workflow that combines metadata and artifact build-infos
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/test_execute-build-workflow.yaml |
Updates parameter name from build-version to build-id and modifies test script |
.github/workflows/test_deploy-artifacts-workflow.yaml |
Adds build-id and metadata-build-id parameters for hierarchical build-info |
.github/workflows/reusable_sign-artifacts.yaml |
Adds artifact-name output and updates checkout reference |
.github/workflows/reusable_execute-build.yaml |
Major refactoring to support build-info publishing and working directory configuration |
.github/workflows/reusable_deploy-artifacts.yaml |
Implements hierarchical build-info aggregation with metadata and artifact build IDs |
.github/workflows/reusable_create-release-bundle.yaml |
Updates checkout reference to feature branch |
.github/workflows/execute-build/entrypoint.sh |
Adds build-info collection and publishing functionality |
.github/workflows/execute-build/README.md |
Updates documentation to reflect parameter changes |
.github/workflows/example_reusable-integration.yaml |
Demonstrates new build-info workflow with multiple build IDs |
.github/workflows/deploy-artifacts/test-entrypoint.sh |
Updates tests for new parameter structure and command expectations |
.github/workflows/deploy-artifacts/entrypoint.sh |
Major refactoring for hierarchical build-info and artifact discovery |
.github/workflows/deploy-artifacts/README.md |
Updates documentation for new build-info parameters |
.github/workflows/VERSION.example |
Bumps version from 1.2.3 to 1.2.4 |
Comments suppressed due to low confidence (1)
.github/workflows/deploy-artifacts/entrypoint.sh:1
- The variable BUILD_ID is no longer defined since line 116 removed the BUILD_ID assignment. This should use BUILD_NUMBER instead.
#!/usr/bin/env bash
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
no matter what when last commit is made need to tag and update refs to latest commit |
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
…ommand executions
…se commit hash Updated workflow files to use the latest commit hash for the shared workflows repo
Added 'fetch-tags' and 'recursive' options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements build info aggregation in the build step as part of INFRA-189, enabling JFrog build-info collection during the build process and creating a hierarchical build-info structure in the deploy step.
Breaking Changes:
build-version→build-idparameter rename inreusable_execute-build.yamlbuild-idinput inreusable_deploy-artifacts.yamlmetadata-build-idinput inreusable_deploy-artifacts.yaml