[regression] Suppress routine connect notices during startup#2852
Open
jensenpat wants to merge 1 commit into
Open
[regression] Suppress routine connect notices during startup#2852jensenpat wants to merge 1 commit into
jensenpat wants to merge 1 commit into
Conversation
Co-authored-by: Codex <noreply@openai.com>
Contributor
There was a problem hiding this comment.
Thanks @jensenpat — this looks like a clean, well-scoped regression fix. A few observations:
Looks good
- Refactor of the inline timer check into
armClientConnectionNoticeSuppression()/clientConnectionNoticeSuppressionActive()is a nice readability win and keeps the four arming points consistent. - The new
isRoutineClientConnectionInfo()helper drops naturally into the existing anonymous namespace and uses astatic const QRegularExpressionlike the surrounding patterns. - Suppression is correctly gated on
MessageSeverity::Infoonly, so Warning/Error/Fatal radio messages still surface — important for the operator-facing surface. - The early-return for
MessageType::HandleinonMessageReceived()is safe: that handler previously only dispatched onMessage/Statusand fell through silently for everything else. Arming the gate there closes the ordering hole described in the comment. - Re-arming around
client guiresponse and just beforesub client allis the right pair of hook points to keep the startup status replay quiet without affecting later joins.
One minor thing
bool isRoutineClientConnectionInfo(const QString& text)matches bothconnectedanddisconnected. The PR description only mentions connect notices, but the broader regex looks intentional (disconnect replays during the same startup window would be equally noisy). Worth confirming that's deliberate — if so, no change needed.
Nothing blocking. Nice surgical fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Client connected from IP ...while the startup connection-notice grace window is active.M-message notices and client status replay notices.Why
During initial radio connection, the radio can emit routine informational connection messages before the normal connected-client status replay finishes. Those self-connect notices should remain quiet during startup, while warning, error, and fatal radio messages should continue to surface normally.
Validation
cmake -S . -B build -G Ninja -DCMAKE_BUILD_TYPE=RelWithDebInfocmake --build build --parallel 22ctest --test-dir build --output-on-failure --parallel 22— 15/15 passedbuild/AetherSDR.app👨🏼💻 Generated with OpenAI Codex (GPT-5.5 Pro 4/23) and tested by @jensenpat