Fix: Adapt to new bahaviour of bevy_picking with bevy_window::window:…#60
Closed
ccoder1337 wants to merge 2 commits intoaevyrie:mainfrom
Closed
Fix: Adapt to new bahaviour of bevy_picking with bevy_window::window:…#60ccoder1337 wants to merge 2 commits intoaevyrie:mainfrom
ccoder1337 wants to merge 2 commits intoaevyrie:mainfrom
Conversation
ccoder1337
force-pushed
the
fix/picking_window_sussy_baka
branch
3 times, most recently
from
eb21249 to
4fa69bc
Compare
Author
|
#56 seems to fix it already. This is a slightly different approach. I'll just leave it as draft. |
ccoder1337
force-pushed
the
fix/picking_window_sussy_baka
branch
from
4fa69bc to
b11ac65
Compare
Author
|
Actually no don't merge this this is not backward compatible to 0.17.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Fixes #55.
If background is clicked a hit on Window is registered with hit.position holding the pointer coordinates in screen space.
This was apparently changed in bevyengine/bevy/pull/21802.
There may be several possible approaches, but I removed the default case where pointer position is manually retrieved.
I also removed unnecessary checking of zoom velocity when EditorCam.current_motion.is_zooming_only() is false. If that's not wanted in this PR I can remove it.