Skip to content

fixed unit test for simple service stop_announce method #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
AlwinHughes wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fixed unit test for simple service stop_announce method #26

AlwinHughes wants to merge 2 commits into from

Conversation

@AlwinHughes
Copy link
Contributor

@AlwinHughes AlwinHughes commented Jan 5, 2025 •
edited
Loading

I've fixed the unit test for the simple service stop_announce method.
This was broken in my last MR (#23) where we switched from passing a config.Service to a ServiceInstance object to the ServiceAnnouncer announce_service metho.` I think this fixes it.

I'm not very familiar with pytest and I don't really follow why the self.prot line was needed before but it seems to fail the test now so I've removed it.

I've also updated the announce_service test to check the whole service instance object rather than just the service_instance.config object

@AlwinHughes AlwinHughes marked this pull request as ready for review January 5, 2025 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@AlwinHughes