feat: add Kilo Code support and model selection to ACP configurations - #3101
Open
vvlrff wants to merge 5 commits into
Open
feat: add Kilo Code support and model selection to ACP configurations#3101vvlrff wants to merge 5 commits into
vvlrff wants to merge 5 commits into
Conversation
vvlrff
marked this pull request as ready for review
July 24, 2026 21:22
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Two gaps in the ACP integration:
ACPConfig.modelwas response metadata only — there was no way to actuallyselect the CLI agent's model from AG2.
This PR:
ACPConfig.modelat session start via ACPsession/set_config_optionwhen the agent advertises a model picker in
session/new(Claude Code,OpenCode and Kilo Code all do). A value equal to the agent's current model is
not re-sent; a model not offered by the agent raises
ValueError; agentswithout a model option keep the previous metadata-only behavior.
KiloCodeConfig— anACPConfigpreset launchingkilo acp.modelshould always be set explicitly, since a fresh Kilo ACP session may default
to an unsuitable model.
fake_acp_configtesting double withconfig_options/config_option_callsseams, so e2e tests cover model selection through thepublic API only.
website/docs/user-guide/cli_agents.mdx).Checks
AI assistance