Skip to content

Conversation

Saransh-cpp
Copy link
Contributor

A subset of #2017 containing minimal changes related to finiteness

@laMudri
Copy link
Contributor

laMudri commented Jul 13, 2023

This PR on its own fails the “definitions should come with proofs” test, but maybe it's permissible with the promise of proofs in a later PR. We'll have to let the maintainers decide.

@Saransh-cpp
Copy link
Contributor Author

Yes, that is very true. I just don't how to include the proofs without bringing in a lot more changes (which should be in separate PRs according to the discussions in #2017).

@MatthewDaggitt MatthewDaggitt added this to the v2.1 milestone Sep 26, 2023
@jamesmckinna jamesmckinna mentioned this pull request Mar 25, 2024
@jamesmckinna
Copy link
Contributor

jamesmckinna commented Jun 6, 2024

(Overlooked in yesterday's meeting)
Suggest at the very least that we bump this to v2.2, or even close (cf. #2005 ) until/unless someone comes along able to pick up the slack?

@jamesmckinna jamesmckinna removed this from the v2.1 milestone Jun 6, 2024
@JacquesCarette JacquesCarette added this to the v2.2 milestone Jun 7, 2024
@JacquesCarette
Copy link
Contributor

I put it in v2.2 as I really would like to push this through.

@JacquesCarette JacquesCarette self-assigned this Jun 7, 2024
Comment on lines +43 to +45
Apex : Setoid c′ ℓ′
finitelyEnumerable : FinitelyEnumerable Apex
inj : Injection X Apex
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JacquesCarette I can just about take Apex as the name of the 'covering object' A in an epic situation A → X (L52-L54 below), but it seems less defensible here in the dual situation X → A. Is it 'standard' terminology? Or is there something better from eg the categorical literature?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is probably too influenced by other code / ideas, and no longer really fits here. Suggestions?

Copy link
Contributor

@jamesmckinna jamesmckinna Sep 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hunted around, and unfortunately the literature uses 'generic' names such as X, Y/A, B when discussing things as morphisms. For embedding/extension, the domain of an injection is sometimes called I, and of a projection as P, but these don't seem quite satisfactory, either?

In each case, though, the relevant object is (suitably) enumerable, so could it be called Enum, or even Enumeration?... Or even simply E?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enumeration > Enum > E.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK!?

@jamesmckinna
Copy link
Contributor

I put it in v2.2 as I really would like to push this through.

Comments on notation. I'd like to see this too, but as a fresh addition, we should try to get a 'convenient'/usable/memorable syntax/naming convention fixed before committing...

@MatthewDaggitt
Copy link
Contributor

I've converted this to a draft. @JacquesCarette when it's ready to review properly, turn it back again 👍

@JacquesCarette
Copy link
Contributor

We've decided to close this for now, in favour of the "project issue #2511 " as it's a bigger deal.

@Saransh-cpp Saransh-cpp deleted the finiteness branch December 6, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants