-
Notifications
You must be signed in to change notification settings - Fork 260
Add Data.Nat.Binary.Base.divMod
#2029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Oops, did not see that |
|
Thank you for this PR, this is definitely a worthwhile addition to the library. Have you managed to do any form of benchmarking? |
|
@Taneb No, unfortunately I'm not very familiar with benchmarking. |
|
CI reports failure: https://github.com/agda/agda-stdlib/actions/runs/5636154398/job/15267920707#step:10:654 |
|
@andreasabel Yep, it was nothing serious, just some naming conflicts in |
|
What happened here? |
|
@jamesmckinna I forgot this hasn't been merged and discarded my commits because there seemed to be conflicts with the upstream. Didn't know this happened. Sorry. |
Long division for
Data.Nat.Binaryas well as some related functions. This is still a draft. I will probably add some properties later.