remove unnecessary condition in the Relation.Binary.Reasoning.Base.Apartness
#2438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damhiya
changed the title
Relation.Binary.Reasoning.Base.Apartness
JacquesCarette
requested changes
Jul 11, 2024
|
Is there any opinion about changing the module name? |
|
Sorry for the long reply time.
As always, it's easy to say the current name isn't the best. Do you have a better suggestion we can compare it with? I personally don't think the current name is terrible. @JacquesCarette would you be willing to approve now? |
MatthewDaggitt
approved these changes
Aug 14, 2024
|
I recommend |
JacquesCarette
approved these changes
Aug 14, 2024
|
Looking in more detail: what's in the file seems quite consistent with its current name - it is base reasoning about an apartness relation! |
|
I'm also tempted to agree with @JacquesCarette. It's also not as if it's a very widely used module outside of the library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transitive _#_condition in the moduleRelation.Binary.Reasoning.Base.Apartnessis unnecessary. Indeed, apartness relation can be transitive only if it is empty, and I think the module name is not appropriate since this module just works for any symmetric relation.