Added AVL.Map suggestion, explanation of MkValue args. #2447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatthewDaggitt
requested changes
Jul 30, 2024
|
Great--thanks. Will do as soon as I get a moment. |
As suggested by @MatthewDaggit. I also lowercased the initial letter after colon in third new paragraph.
MatthewDaggitt
approved these changes
Aug 14, 2024
|
Great, thanks! Merging in. |
|
(Sorry for last comment... deleted because getting mixed up with several other PRs 🤦 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had trouble understanding
MkValuein the exampleTreedefinition. The proposed addition after theTreedefinition briefly summarize what I learned (for future readers with ignorance like mine), without going into what I thought might be unnecessary detail.I also added a suggestion and note about
Data.Tree.AVL.Mapin the "Further reading" section at the end. I feel thatAVL.Mapsatisfies the simplest use cases for theData.Tree.AVL, so it's worth mentioning here.(Sorry about the two commits with the same message. I think I did something wrong when I tried to rebase them into one commit. If it bothers anyone, I'll figure out how to fix it.)