[ refactor ] exchange left and right in Data.List.Relation.Binary.Pointwise etc. congruence rules for _++_
#2535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't want to go either way on this until we decide what left and right mean. |
As discussed also on #2532 there is an internally/locally coherent notion of left/right already present in the affected modules, which the previous PR violated (so: in that sense, a 'bug'), and this restores that internal/local coherence. The 'global' questions of what coherent/consistent design does the library adopt will clearly break some modules in favour of maintaining the choices in others, but that seems a different question to the one at hand of restoring the 'local' choices here. |
|
I'm willing to allow it for #2532 . Local coherence is good. |
JacquesCarette
approved these changes
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a do-over of #2426 , which I think should be regarded as having introduced a bug, which this PR fixes, as well as the original issue #1131 .
This also addresses the left/right issue discussed extensively on the original PR and in #2532 .
Fortunately the original PR was v2.2, so this is not breaking, indeed should be a 'silent' refactoring.
Outstanding issue: refactor further to make use of
LeftCongruentandRightCongruentfromAlgebra.Definitions, which changes explicit quantification as now to implicit quantification... I'm inclined to do this, so feedback welcome!