Conversation
Agda returns 'datatype', not 'type', as the name of datatypes. CornelisType in Pretty.hs will not apply to these (via toAtomName) unless it's named CornelisDatatype. This is the simplest fix. One could add a CornelisType syntax group that both CornelisDatatype and CornelisRecord link to, which might be a little more backwards-compatible with people who do highlight linking around CornelisType. But my guess is that CornelisType has never worked (see agda#153) and so I'm not worrying about backwards compatibility.
Collaborator
|
thanks! |
Contributor
Author
|
I just glanced over this in my inbox, and I realize that my PR had two commits, one of which fixed a different bug. My mistake; sorry. You may wish to look it over and make sure you also want the other bug fix, and/or revert one commit and have me submit a different PR for that (for bookkeeping reasons). |
Collaborator
|
it's alright i thought both should be included |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes curly braces from iskeyword. Probably unicode ranges should also be added to iskeyword so that symbols like ≡ are recognized by (n)vim as legal parts of names, but I can't be bothered to check what unicode ranges to add or how unicode ranges in iskeyword interact with the file encoding (to make sure it works cross-platform), and this is a quick and easy fix.