Skip to content

Conversation

@muscariello
Copy link
Member

@muscariello muscariello commented Dec 11, 2025

Title: Fix Tourist Scheduling System "Real Agents" Demo

Description

This update resolves several critical issues preventing the "Real Agents" demo (./run.sh --real-agents) from running successfully. The fixes span the transport layer, data serialization, and process orchestration.

Key Issues Addressed

  1. Transport Layer Crash (request_metadata)

    • Problem: The SLIM transport layer was passing a request_metadata argument to the underlying Google ADK transport, which caused a TypeError as the ADK does not support this argument.
    • Fix: Implemented CustomSRPCTransport in src/core/slim_transport.py to intercept calls and filter out request_metadata while preserving extensions before delegating to the ADK.
  2. Serialization Error (ValueError: Unexpected type)

    • Problem: The agents were attempting to send raw Pydantic models (e.g., Assignment, Proposal) directly to the ADK. The ADK's Protobuf serializer requires standard Python types (dicts/lists), resulting in a crash.
    • Fix: Updated src/agents/tools.py to explicitly serialize Pydantic models using .model_dump(mode='json') before transmission.

@muscariello muscariello requested a review from a team as a code owner December 11, 2025 17:36
@muscariello muscariello requested a review from paralta December 11, 2025 17:36
@muscariello muscariello linked an issue Dec 11, 2025 that may be closed by this pull request
@muscariello muscariello removed the request for review from paralta December 11, 2025 17:37
@muscariello muscariello changed the title Fix Tourist Scheduling System Real Agents Demo fix: Tourist Scheduling System Real Agents Demo Dec 11, 2025
@muscariello muscariello requested a review from msardara December 11, 2025 17:37
@muscariello muscariello force-pushed the 113-upgrade-to-slima2a-022 branch from 63ba651 to 41a41ed Compare December 11, 2025 17:38
@muscariello muscariello requested a review from lgecse December 11, 2025 17:40
Copy link
Member

@lgecse lgecse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@muscariello muscariello merged commit 9165088 into main Dec 11, 2025
7 checks passed
@muscariello muscariello deleted the 113-upgrade-to-slima2a-022 branch December 11, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade to slima2a 0.2.2

3 participants