Open
Conversation
Signed-off-by: DaevMithran <daevmithran1999@gmail.com>
Signed-off-by: DaevMithran <daevmithran1999@gmail.com>
Member
|
Hi @DaevMithran, thank you for your contribution! Although this is LGTM from my end, I do want to ask for some supporting material, either as part of documentation or some simple guide in terms of:
Although the current PR only supports JS clients to make use of DIDs, I think it is okay to support other clients (go/python/cli) later on. Regarding the PR itself, we may want to cover this with at least one test case that would help us maintainers understand the setup. In that regard, having a script/document/rfc/testcase that at least showcases the usage of DID would be extremely helpful. If you have a working approach to utilising DIDs at the moment, that would also be very beneficial. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds DID-based authentication alongside existing SPIFFE/SPIRE modes for decentralized identity networks.
Changes
New Authentication Mode