Skip to content

Conversation

@mtrinell
Copy link
Member

Description

Adds e2e test (with a test webapi server) for webhook feature

Signed-off-by: Marco Trinelli (mtrinell) <[email protected]>
@mtrinell mtrinell requested a review from a team as a code owner May 15, 2025 10:07
@mtrinell mtrinell requested a review from lpuskas May 15, 2025 10:07
@github-actions
Copy link

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@mtrinell mtrinell requested review from janosSarusiKis and removed request for lpuskas May 15, 2025 10:08
import json
from typing import AsyncGenerator, List, Optional

from aiohttp import web
Copy link
Member Author

@mtrinell mtrinell May 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't make fastapi work here (looks like it collides with the other fastapi server, being in the same event loop) - so using aiohttp

Copy link
Contributor

@janosSarusiKis janosSarusiKis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mtrinell mtrinell merged commit 56d24ea into main May 15, 2025
5 checks passed
@mtrinell mtrinell deleted the webhook-tests branch May 15, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants