Melodic #2
Melodic #2
Conversation
| } | ||
| ], | ||
| "version": 4 | ||
| } No newline at end of file |
There was a problem hiding this comment.
As GitHub suggests a newline is missing at the end of file.
There was a problem hiding this comment.
I see that GitHub doesn't warn about it everywhere (here not). However generally all files on Unix likes should have an empty line at the bottom.
Git sometimes warns about this too.
| "python.autoComplete.extraPaths": [ | ||
| "/opt/ros/melodic/lib/python2.7/dist-packages" | ||
| ] | ||
| } No newline at end of file |
There was a problem hiding this comment.
As GitHub suggests a newline is missing at the end of file.
| echo -e "${GREEN}Gazebo installation done${NOCOLOR}" | ||
| # read -p "Do you wish to install simulator (Gazebo) [Y/n]" -n 1 -s ans && echo | ||
| # [ "${ans}" != "n" ] && install_gazebo | ||
| # echo -e "${GREEN}Gazebo installation done${NOCOLOR}" |
| python-wstool | ||
| build-essential | ||
| ros-melodic-ros-control | ||
| ros-melodic-ros-controllers |
| sudo apt update | ||
| sudo apt -y install --no-install-recommends `cat pkglist-ros` | ||
|
|
||
| echo "source /opt/ros/melodic/setup.bash" >> ~/.bashrc |
There was a problem hiding this comment.
This is redundant with
Afaik source is needed to the run commands below. The best would be to place source /opt/ros.... on this line. And leave mentioned line in other file as is.
| sudo apt -y install --no-install-recommends `cat pkglist-ros` | ||
|
|
||
| echo "source /opt/ros/melodic/setup.bash" >> ~/.bashrc | ||
| source ~/.bashrc |
There was a problem hiding this comment.
If what I wrote above is ok this would be not needed.
| echo "source /opt/ros/melodic/setup.bash" >> ~/.bashrc | ||
| source ~/.bashrc | ||
|
|
||
| sudo apt install python-rosdep |
There was a problem hiding this comment.
Shouldn't this go to the pkglist?
No description provided.