Add link unfurl for PRs and issues #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ygrek
approved these changes
Dec 30, 2020
yasunariw
force-pushed
the
yasu/slack-unfurl-links-pr-issue
branch
from
810f7e9 to
f8b1e4b
Compare
yasunariw
force-pushed
the
yasu/slack-unfurl-links
branch
3 times, most recently
from
3200af0 to
cfc4921
Compare
yasunariw
force-pushed
the
yasu/slack-unfurl-links-pr-issue
branch
from
f8b1e4b to
b7ccbe7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the task
(depends on #101 )
This PR extends the link unfurling feature to handle issue and PR links. Visually, it follows the style of GitHub's official Slack integration.
How to test
This shouldn't affect existing tests. New tests for url pattern matching are defined in
tests/github_link_test.ml. You can also test by posting messages w/ links to a channel the bot is a member of.References